Specialize integer numeric driver bindings #4588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow specialization of integer types to match more of the ones in JdbcDriver.
The Postgres JDBC driver and wire protocol treat varying integer sizes differently. For example, an Int only transfers 4 bytes, while Long transfers the full 8. Since we have the ability to call the proper JDBC methods, we should do so.
MariusVolkhart
force-pushed
the
mv/postgresTypes
branch
from
32b9f12
to
1e97d2c
Compare
hfhbd
pushed a commit
that referenced
this pull request
Apr 2, 2024
* Add overloads to R2dbcDriver for fine-grained types Allow specialization of integer types to match more of the ones in JdbcDriver. * Specialize Postgres integer JDBC interactions The Postgres JDBC driver and wire protocol treat varying integer sizes differently. For example, an Int only transfers 4 bytes, while Long transfers the full 8. Since we have the ability to call the proper JDBC methods, we should do so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use specialized methods for interacting with the drivers when working with integer numeric types in Postgres. The
JdbcDriveralready had support for this. Support for theR2dbcDriverhas been added.Specialization on Postgres makes a difference to what gets sent over the wire. I didn't look into other DBMS.